Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add v13 support #43

Merged
merged 1 commit into from
Apr 16, 2024
Merged

add v13 support #43

merged 1 commit into from
Apr 16, 2024
+48 −32

Conversation

chaitanyapotti
Copy link
Member

No description provided.

@chaitanyapotti chaitanyapotti requested a review from ieow April 15, 2024 14:15
himanshuchawla009
himanshuchawla009 reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, metadata url should be handled carefully. Release notes should mention if someone has hardcoded metadata url previously, they should keep using that otherwise account will change.

ieow
ieow approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ieow ieow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 9747a59 into master Apr 16, 2024
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/v13 branch April 16, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 left review comments

@ieow ieow ieow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaitanyapotti @ieow @himanshuchawla009